[Select][Joy] Fix forwarding listbox component
prop
#34172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #34164
Preview: https://deploy-preview-34172--material-ui.netlify.app/joy-ui/react-select/#grouped-options
Root cause
By provided
component: 'div'
to the listbox slot, the div replace theSelectListbox
slot instead of passing asas
prop. That's why the styles are gone.To fix this problem, the component must be specified at the end to
PopperUnstyled
and grab the finalcomponent
from listbox slot props (because it could be a callback) to pass it asas
prop.A visual regression test is added https://app.argos-ci.com/mui/material-ui/builds/4844