[Paper] Allow the box shadow color to be changed #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -109,6 +109,16 @@ export default function getMuiTheme(baseTheme, muiTheme) { | |||
| }, | |||
| paper: { | |||
| backgroundColor: palette.canvasColor, | |||
| zDepthShadows: [null].concat([ | |||
There was a problem hiding this comment.
Any reason for using concat?
|
If you think the code is okay now, I can squash the commits to have a cleaner merge ;) |
tibdex
changed the title
tibdex
changed the title
| [14, 45, 0.25, 10, 18, 0.22], | ||
| [19, 60, 0.30, 15, 20, 0.22], | ||
| ].map(d => { | ||
| const shadowColor = palette.shadowColor || Colors.fullBlack; |
There was a problem hiding this comment.
I don't know what to think about palette.shadowColor.
That's kind of an undocumented hidden feature.
That makes me think that we should add it to the lightBaseTheme.
(I know, I asked you to remove it, sorry 😁)
@alitaheri @newoga What do you think about using palette.shadowColor in this file and adding shadowColor: Colors.fullBlack in the lightBaseTheme.jsx?
There was a problem hiding this comment.
Yup I agree, I think that makes more sense 👍
oliviertassinari
added
PR: needs revision
|
I squashed everything into one small commit to have a cleaner log ;) |
oliviertassinari
added
PR: Review Accepted
and removed
PR: needs revision
oliviertassinari
added a commit
that referenced
this pull request
Jan 25, 2016
[Paper] Allow the box shadow color to be changed
|
@tibdex Merci! |
zannager
added
the
component: Paper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows dark or custom themes to change the box-shadow color of paper elements