Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use for...of on table children. #2904

Merged
merged 1 commit into from
Jan 12, 2016
Merged

Don't use for...of on table children. #2904

merged 1 commit into from
Jan 12, 2016

Conversation

STRML
Copy link
Contributor

@STRML STRML commented Jan 12, 2016

We can't assume children is an array, as it is a single
element when only one child is passed.

Fixes #1531, #1972, #2058 and removes need for a Symbol
polyfill.

@STRML
Don't use for...of on table children.
7c4df70 
We can't assume `children` is an array, as it is a single
element when only one child is passed.

Fixes mui#1531, mui#1972, mui#2058 and removes need for a Symbol
polyfill.
@alitaheri
Copy link
Member

Thanks a lot @STRML 👍 👍

alitaheri added a commit that referenced this pull request Jan 12, 2016
@alitaheri
Merge pull request #2904 from STRML/fixTable
2592cda 
Don't use for...of on table children.
@alitaheri alitaheri merged commit 2592cda into mui:master Jan 12, 2016
This was referenced Jan 24, 2016
Closed
Merged
@oliviertassinari oliviertassinari mentioned this pull request Feb 9, 2016
Merged
@zannager zannager added the component: table This is the name of the generic UI component, not the React module! label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: table This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table component is broken on webkit
3 participants
@STRML @alitaheri @zannager