[Docs] Improve the AppLeftNav for mobile #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
oliviertassinari
changed the title
|
@alitaheri @Zadielerick Are you ok to merge this? |
| @@ -265,7 +265,7 @@ const LeftNav = React.createClass({ | |||
| transform: `translate3d(${x}px, 0, 0)`, | |||
| transition: !this.state.swiping && Transitions.easeOut(), | |||
| backgroundColor: theme.color, | |||
| overflow: 'hidden', | |||
| overflow: 'auto', | |||
There was a problem hiding this comment.
I think that it's the most questionable change of this PR.
There was a problem hiding this comment.
@oliviertassinari I think its fine. I don't see why someone would want to make their overflow hide. And it's easily overridden with styles.
There was a problem hiding this comment.
@oliviertassinari That would actually close a bunch of issues. 😁
alitaheri
added a commit
that referenced
this pull request
Dec 30, 2015
[Docs] Improve the AppLeftNav for mobile
|
@oliviertassinari Thanks a lot @oliviertassinari 🎉 🎈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2616, and start adressing #2435.
I think that we should get ride of the
PageWithNavcomponent.Instead, I would use the
AppLeftNavnot only for the mobile view, but also for the desktop view with adocked={true}property.