[IconButton] Remove label span #26801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
breaking change
component: icon button
siriwatknp
commented
Jun 17, 2021
| @@ -1019,6 +1019,16 @@ You can use the [`collapse-rename-collapsedheight` codemod](https://github.com/m | |||
| + <IconButton size="large"> | |||
| ``` | |||
|
|
|||
| - `span` element that wraps children has been removed. `label` classKey is also removed. Read more about [span removal](https://github.com/mui-org/material-ui/pull/26666). | |||
There was a problem hiding this comment.
I think developer might be curious about why it is removed, so link to the description of the PR.
siriwatknp
force-pushed
the
fix/icon-button-span
branch
from
fc91f2d
to
a082950
Compare
siriwatknp
commented
Jun 17, 2021
| @@ -631,7 +631,7 @@ You can use the [`moved-lab-modules` codemod](https://github.com/mui-org/materia | |||
|
|
|||
| You can use the [`button-color-prop` codemod](https://github.com/mui-org/material-ui/tree/HEAD/packages/material-ui-codemod#button-color-prop) for automatic migration. | |||
|
|
|||
| - `span` element that wraps children has been removed. `label` classKey is also removed. | |||
| - `span` element that wraps children has been removed. `label` classKey is also removed. More details about [this change](https://github.com/mui-org/material-ui/pull/26666). | |||
There was a problem hiding this comment.
I think developer might be curious why it is removed, so I link to the description of the PR.
eps1lon
approved these changes
Jun 17, 2021
mnajdova
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
spanelement that wraps children has been removed.labelclassKey is also removed. More details about this change.follow up of #26666
preview 👉 https://deploy-preview-26801--material-ui.netlify.app/components/buttons/#icon-button