[ES6] Use module everywhere #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,78 +1,226 @@ | |||
| import AppBar from './app-bar'; | |||
There was a problem hiding this comment.
If we can get the babel 6 in with the state 1 preset, we can use the export extensions to simplifiy this.
All of them can be like:
export {AppBar} from './app-bar';There was a problem hiding this comment.
That's good to know.
There was a problem hiding this comment.
Hello, I see that 1 line export is not considered a good practice. https://github.com/airbnb/javascript#10.3
There was a problem hiding this comment.
They are bad for files that perform logic, true. but for files that the only thing they do is re-export i think it makes sense. without this syntax the number of lines become excessively large and hard to maintain.
|
@newoga Yeah, but babel 6 proved too difficult apparently, for now this is good enough. |
oliviertassinari
added a commit
that referenced
this pull request
Dec 21, 2015
[ES6] Use module everywhere
|
Thanks 🎉 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2558.