-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Box] Remove the clone
prop
#26031
[Box] Remove the clone
prop
#26031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor suggestions
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
- <Button>Save</Button> | ||
-</Box> | ||
+<Button sx={{ border: '1px dashed grey' }}>Save</Button> | ||
``` | ||
|
||
2. Use render props |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we can drop this as well. It was added to solve the same problem that sx
handles now.
Maybe a follow up or in the same PR? I mean, the problem we go after is the same, so happy with both options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A follow up PR is better for the release notes.
Breaking changes
[Box] Remove the
clone
prop because its behavior can be obtained using thesx
prop.Part of #20012
Closes #18496