Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextField] Make the position prop required in InputAdornment #25891

Merged
merged 2 commits into from
Apr 23, 2021
Merged

[TextField] Make the position prop required in InputAdornment #25891

merged 2 commits into from
Apr 23, 2021

Conversation

m4theushw
Copy link
Member

Part of #20012

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 22, 2021 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 2024c4a

@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 22, 2021 •
edited
Loading

Did you find the context on why? I can't recall the motivation.

@oliviertassinari
Copy link
Member

Oh yes, I remember, it's because we don't use the context to infer the placement from the startAdornment or endAdornment prop. All the demo provide the prop anyway. It sounds good. It's not really a breaking change, more a cleanup. And in the future, we can consider using the context.

@github-actions github-actions bot mentioned this pull request Apr 22, 2021
Closed
@m4theushw
Copy link
Member Author

Actually, the prop is already required in the .d.ts file in v4. It was made optional in v5 here. I think we don't need to update the migration guide. Just adding an isRequired in v4 is fine.

@oliviertassinari oliviertassinari added the component: text field This is the name of the generic UI component, not the React module! label Apr 22, 2021
@m4theushw m4theushw merged commit f389f2c into mui:next Apr 23, 2021
@m4theushw m4theushw deleted the inputAdornment branch April 23, 2021 12:07
@m4theushw m4theushw mentioned this pull request Apr 23, 2021
Merged
1 task
@oliviertassinari oliviertassinari mentioned this pull request Apr 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m4theushw @mui-pr-bot @oliviertassinari @eps1lon