Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Migrate Checkbox demos to emotion #25394

Merged
merged 13 commits into from
Mar 18, 2021
Merged

[docs] Migrate Checkbox demos to emotion #25394

merged 13 commits into from
Mar 18, 2021

Conversation

vicasas
Copy link
Member

@vicasas vicasas commented Mar 17, 2021

The following demos of the Checkbox component were migrated:

  • Indeterminate
  • Label
  • FormGroup
  • Customized checkbox

Related to #16947

@vicasas vicasas mentioned this pull request Mar 17, 2021
Closed
89 tasks
@mui-pr-bot
Copy link

mui-pr-bot commented Mar 17, 2021 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 6e51db9

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Mar 17, 2021
oliviertassinari
oliviertassinari requested changes Mar 18, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The keyboard focus visible on the customizaton demo is broken

@github-actions github-actions bot mentioned this pull request Mar 18, 2021
Closed
@vicasas
Copy link
Member Author

vicasas commented Mar 18, 2021

The keyboard focus visible on the customizaton demo is broken

Resolved

oliviertassinari
oliviertassinari approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have used the opportunity to breakdown the existing demos. Much better :)

@vicasas
Copy link
Member Author

vicasas commented Mar 18, 2021

I have used the opportunity to breakdown the existing demos. Much better :)

Sure! by default it uses the primary. I will be more careful in the next 🎉

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 18, 2021 •
edited
Loading

I will be more careful in the next

@vicasas I didn't see any mistake in the migration. Well done. The changes I have done were to further improve the page.

@oliviertassinari oliviertassinari merged commit ea2bd5a into mui:next Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vicasas @mui-pr-bot @oliviertassinari