[Doc] Update menu implementation on left nav

[newoga]

This pull request is in support of deprecating the old menu components. (related to #2395, #2307)

It replaces the menu implementation on the left nav on the docs site with the new one.

As a result, it also fixes #1514

[newoga]

Note: I also change the zIndex of the header from 6 to 15 because the menu has a default zIndex of 10. I figured it'd be better to change the header so that components in the code examples don't go over the header which I've seen reported in other issues.

[alitaheri]

👍 Nice work. @oliviertassinari Please review and don't mind the code-style (const, extra empty line, etc...) I'm working on them. merge this if it's semantically alright.

[oliviertassinari]

React plan to deprecate valueLink.
Could we not use this property?

[newoga]

I didn't know valueLink was being deprecated...I'm not a huge fan of it anyway :P

Was just implementing it the easiest way I saw possible from the menu docs, I'll find another way.

[oliviertassinari]

Have a look at facebook/react#5032. This will help

[oliviertassinari]

@newoga Thanks for working on this. That's an excellent idea!

[newoga]

Hey @oliviertassinari,

I just pushed a new commit with your fixes/suggestions. I think the best way to implement the active route on page load is to pass the router's location down to the navbar component through props so that it is more stateless. It resulted in having to modify the page and master components.

I originally implemented this by looking at window.location.hash, but I think using the router location is the cleaner approach.

Let me know what you think!

[oliviertassinari]

@newoga This works great, thanks!

I just had another idea. I don't know if you are going to like it.
I think that we should group component by type. For instance, we could creat a Form group
with the SelectField and the TextField. In this case, Using a List may be more appropriate.
Similary to https://www.google.com/design/spec/components/tabs.html.
I also think that this left panel should be in a LeftNav, again, using a List over a Menu would probably makes more sens 😁.

Still, I can merge this PR, since it's already far better.

[alitaheri]

@oliviertassinari Should we discuss this with others in a separate issue? I mean the categorization is a big decision, this PR handles something else imo. 😬

[oliviertassinari]

@subjectix Alright.
@newoga Could you squash down the commit, I will merge!

[newoga]

Haha, that's irony for you! I feel like I've been switching from List to Menu to List a lot lately 😝 That being said, I do agree that using the LeftNav would be preferable. Initially I was just trying to do the least amount of work to remove the old Menu just so we can drop it as a dependency.

I'll squash and can create a new issue for <PageWithNav /> improvements so that we can discuss more.

(Don't feel bad about suggesting a different approach, I certainly don't mind iterating and definitely prefer getting things right the first time. Worst case scenario I'll flip my table and no one will have to know 😄)

[oliviertassinari]

@newoga Thanks

[alitaheri]

@newoga Thanks a lot 👍 👍 🎉

[oliviertassinari]

Why changing this?

[oliviertassinari]

I see, I have another issue with zIndex now.
I'm gonna fix it.