-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Allow React 17 in peer dependencies #23697
Conversation
ca25304
to
4f3dd3d
Compare
11d0e1b
to
e8c4497
Compare
Details of bundle changes.Comparing: b8092ce...7739008 Details of page changes
|
🎉 |
2b9bcef
to
3dc1e09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No argument I made changed. We shouldn't do this. You're purposely hiding potential problems and I will not support this behavior.
I'm also against this support policy. We're missing ~5 people that work on the public OSS part to support that.
This reverts commit 49fa786.
@eps1lon Is the main concern that if issues arise with React 17 in v4, we will have to fix them fast because it's the stable version, where with v5-alpha we can take longer if we need to? |
Our codesandbox and examples have been powered by React 17 for the last 5-6 weeks. I believe it's the first time we are in such a situation, we never had a similar case to handle during previous major iterations. Either they were no changes among our peer dependencies or they were breaking. Considering that most dev teams can upgrade React 17 with no issues, I think that we have more to gain by updating too. In the worse case, we will know sooner about the potential issues, the community will be incentives to help fix them (as they can directly benefit from the fixes, not wait 6 months or handle the breaking changes like on v5). If the fix requires a breaking change, then we will only fix it in v5 but at least, we would get partial support for React 17, that developers already use Material-UI v4 with anyway. I will handle the overhead if necessary. |
Could you push a new release out in order to fetch these changes with npm? I tried the master branch directly:
but it's ruining my imports. |
Fix #23306