[docs] Fix /api client-side routing #23586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
eps1lon
commented
Nov 17, 2020
Comment on lines
+193
to
+195
| .map((page) => { | ||
| return { ...page, linkProps: { as: page.pathname.replace(/^\/api-docs/, '/api') } }; | ||
| }), |
eps1lon
force-pushed
the
docs/api-docs-rewrites
branch
from
8499a91
to
7345db8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy with all locales (for routing testing): https://5fb41a5e69a49d000885d0cb--material-ui.netlify.app/
Currently navigating to
/apipages from within the docs triggers a full page reload.I assumed that
rewriteswas working for client-side routing since that was nextjs maintainers explicitly told us. Butrewritesdon't have any effect onnext export. We can achieve the same effect withLink#asit seems.Used the opportunity to type-check the parts that I worked on.