Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ToggleButton] Move from lab to core #22784

Merged
merged 6 commits into from
Oct 3, 2020
Merged

[ToggleButton] Move from lab to core #22784

merged 6 commits into from
Oct 3, 2020

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented Sep 27, 2020 •
edited by oliviertassinari
Loading

Breaking changes

  • [ToggleButton] Move the component from the lab to the core. The component will be stable.

    -import ToggleButton from '@material-ui/lab/ToggleButton';
-import ToggleButtonGroup from '@material-ui/lab/ToggleButtonGroup';
+import ToggleButton from '@material-ui/core/ToggleButton';
+import ToggleButtonGroup from '@material-ui/core/ToggleButtonGroup';

@mbrookes mbrookes added breaking change component: toggle button This is the name of the generic UI component, not the React module! labels Sep 27, 2020
@mbrookes mbrookes added this to the v5 milestone Sep 27, 2020
@mbrookes mbrookes mentioned this pull request Sep 27, 2020
Closed
@mbrookes mbrookes marked this pull request as draft September 27, 2020 23:23
@github-actions github-actions bot mentioned this pull request Sep 27, 2020
Closed
@mui-pr-bot
Copy link

mui-pr-bot commented Sep 27, 2020 •
edited
Loading

@material-ui/core: parsed: +0.81% , gzip: +0.51%
@material-ui/lab: parsed: +0.30% , gzip: +0.05%

Details of bundle changes

Generated by 🚫 dangerJS against 4c7f63b

@mbrookes mbrookes marked this pull request as ready for review September 27, 2020 23:51
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 28, 2020
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 1, 2020
@oliviertassinari oliviertassinari changed the title [ToggleButtons] Move from lab to core [ToggleButton] Move from lab to core Oct 3, 2020
@mbrookes mbrookes merged commit 0c32aa0 into mui:next Oct 3, 2020
@mbrookes mbrookes deleted the togglebuttons-move-to-core branch October 3, 2020 23:05
@oliviertassinari oliviertassinari mentioned this pull request Oct 22, 2020
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
breaking change component: toggle button This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
v5-beta
Development

Successfully merging this pull request may close these issues.
3 participants
@mbrookes @mui-pr-bot @oliviertassinari