[Alert] Move from lab to core

[mbrookes]

Breaking changes

• [Alert] Move the component from the lab to the core. The component will become stable.

  -import Alert from '@material-ui/lab/Alert';
  -import AlertTitle from '@material-ui/lab/AlertTitle';
  +import Alert from '@material-ui/core/Alert';
  +import AlertTitle from '@material-ui/core/AlertTitle';

[oliviertassinari]

@mbrookes What do you think about we re-export the Alert in the lab from the core up until v5.1.0. This would avoid forcing developers to rename imports when they update the dependency. Making the migration a bit smoother.

[mbrookes]

I was going to do that for 4.x (with deprecation warnings), but sure, we could do that here too.

[oliviertassinari]

@mbrookes What's the advantage of doing it for v4? I think that we could only handle v5, the components are unstable in v4. Would making the lab components stable in v4 conflict with the objective to make them stable as an incentive to upgrade? What about if we need to make a breaking change to them?

[mui-pr-bot]

@material-ui/core: parsed: +1.34% , gzip: +0.98%
@material-ui/lab: parsed: +0.36% , gzip: -0.04% 😍

Details of bundle changes

Generated by 🚫 dangerJS against 2554cad

[mbrookes]

What's the advantage of doing it for v4?

Deprecation warnings.

Would making the lab components stable in v4 conflict

Not stable in core v4, just deprecated in lab v4 (when lab v5 is release), but perhaps that's overkill?

[mbrookes]

Why the heck is the API docs generator script checking for the presence of unit tests?

[eps1lon]

Why the heck is the API docs generator script checking for the presence of unit tests?

To verify that the documented behavior is actually implemented.

[eps1lon]

I would not recommend duplicating the component to prevent bundling it twice. We already introduce breaking changes to apply consistent prop naming so I don't think we need to start being careful now. Especially because imports are codemod-able.

Then we automatically avoid potential documentation conflicts by having one component in two packages.

[mbrookes]

What's the plan here?

updated

[mbrookes]

Oh, of course! 🤦

[oliviertassinari]

From my perspective, we don't need any backport for this in v4, nor will we for any of the other components we move from the lab to the core. Making the import from lab still work already fulfill the objective of making the v4 -> v5 switch easy.

[mbrookes]

Yes – some of the components have been in the lab for so long, I almost forgot that it's perpetually breaking! 🙂

[povilass]

Missing https://github.com/mui-org/material-ui/blob/next/packages/material-ui/src/styles/components.d.ts MuiAlert from material-ui/labs typescript in v5.0.0-alpha.12

[oliviertassinari]

@povilass Thanks for raising it. Do you want to submit a pull request to fix it?

[povilass]

#23028 here you go @oliviertassinari