Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Badge] Rename overlap circle -> circular and rectangle -> rectangular for consistency #22050

Merged
merged 8 commits into from
Aug 3, 2020
Merged

[Badge] Rename overlap circle -> circular and rectangle -> rectangular for consistency #22050

merged 8 commits into from
Aug 3, 2020

Conversation

kodai3
Copy link
Contributor

@kodai3 kodai3 commented Aug 2, 2020 •
edited
Loading

Breaking changes

  • Rename circle to circular and rectangle to rectangular for consistency. The possible values should be adjectives, not nouns:

    -<Badge overlap="circle">
-<Badge overlap="rectangle">
+<Badge overlap="circular">
+<Badge overlap="rectangular">

One item of #21964

@mui-pr-bot
Copy link

Details of bundle changes

Generated by 🚫 dangerJS against 13780ed

@eps1lon eps1lon added breaking change component: badge This is the name of the generic UI component, not the React module! labels Aug 3, 2020
@oliviertassinari oliviertassinari merged commit 89a3cfa into mui:next Aug 3, 2020
kodai3 added a commit to kodai3/material-ui that referenced this pull request Aug 3, 2020
@kodai3
[Badge] Rename overlap circle -> circular and rectangle -> rectangula…
3ca3e96 
…r for consistency (mui#22050)
@kodai3 kodai3 mentioned this pull request Aug 3, 2020
Merged
@eps1lon eps1lon added this to the v5 milestone Aug 4, 2020
This was referenced Aug 5, 2020
Closed
Merged
@mbrookes mbrookes mentioned this pull request Sep 23, 2020
Closed
@mbrookes
Copy link
Member

Hey @kodai3! 👋 Do you think you might be able to add a deprecation warning for this on the master branch?

You can probably find a suitable example to follow in #20012 Deprecations section – PR # prefixed with "Dep:".

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
breaking change component: badge This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
v5-beta
Development

Successfully merging this pull request may close these issues.
5 participants
@kodai3 @mui-pr-bot @mbrookes @oliviertassinari @eps1lon