Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove /test-utils #21855

Merged
merged 1 commit into from
Jul 20, 2020
Merged

[core] Remove /test-utils #21855

merged 1 commit into from
Jul 20, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jul 20, 2020

Remove @material-ui/core/test-utils.

These utilities were no longer maintained and mostly replaced by internal forks.

Part of #17070 which will be closed once I update the testing guide (this week).

Introduces a test/utils barrel file. Import will be unified (and linted) in a separate PR. This one already has quite the "busy" diff.

@eps1lon eps1lon added breaking change package: material-ui Specific to @mui/material labels Jul 20, 2020
@eps1lon eps1lon added this to the v5 milestone Jul 20, 2020
@mui-pr-bot
Copy link

Details of bundle changes

Generated by 🚫 dangerJS against 58272c9

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Should we mention the helpers are gone in the migration guide here or when closing the related issue?

@eps1lon
Copy link
Member Author

eps1lon commented Jul 20, 2020

Should we mention the helpers are gone in the migration guide here or when closing the related issue?

Doing it on the docs PR since that'll happen today anyway.

@eps1lon eps1lon merged commit 44db8ee into mui:next Jul 20, 2020
@eps1lon eps1lon deleted the feat/remove-test-utils branch July 20, 2020 14:08
@eps1lon eps1lon mentioned this pull request Aug 5, 2020
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants