Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pagination] Fix prop forwarding of onChange and page #19964

Merged
merged 7 commits into from
Mar 4, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/material-ui-lab/src/Pagination/Pagination.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ const Pagination = React.forwardRef(function Pagination(props, ref) {
getItemAriaLabel: getAriaLabel = defaultGetAriaLabel,
hideNextButton = false,
hidePrevButton = false,
onChange,
page,
renderItem = item => <PaginationItem {...item} />,
shape = 'round',
showFirstButton = false,
Expand Down
36 changes: 36 additions & 0 deletions packages/material-ui-lab/src/Pagination/Pagination.test.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import * as React from 'react';
import { expect } from 'chai';
import { spy } from 'sinon';
import { createMount, getClasses } from '@material-ui/core/test-utils';
import describeConformance from '@material-ui/core/test-utils/describeConformance';
import { createClientRender } from 'test/utils/createClientRender';
import Pagination from './Pagination';
import { fireEvent } from '@testing-library/dom';

describe('<Pagination />', () => {
let classes;
Expand All @@ -29,4 +31,38 @@ describe('<Pagination />', () => {

expect(container.firstChild).to.have.class(classes.root);
});

it('moves aria-current to the specified page', () => {
const { container, getAllByRole } = render(<Pagination count={3} page={1} />);

// previous, page 1
const [, page1] = getAllByRole('button');
expect(page1).to.have.attribute('aria-current', 'true');
// verifying no regression from previous bug where `page` wasn't intercepted
expect(container.querySelector('[page]')).to.be.null;
});

it('fires onChange when a different page is clicked', () => {
const handleChange = spy();
const { getAllByRole } = render(<Pagination count={3} onChange={handleChange} page={1} />);

// previous, page 1, page 2
const [, , page2] = getAllByRole('button');
page2.click();

expect(handleChange.callCount).to.equal(1);
});

it('does not attach onChange to the root element', () => {
const handleChange = spy();
const { getByRole } = render(
<Pagination count={3} onChange={handleChange} page={1}>
<input defaultValue={1} type="text" />
</Pagination>,
);

fireEvent.change(getByRole('textbox'), { target: { value: '2' } });

expect(handleChange.callCount).to.equal(0);
});
});