Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popper] Fix deep merge of PopperProps #19851

Merged
merged 8 commits into from
Feb 29, 2020
Merged

[Popper] Fix deep merge of PopperProps #19851

merged 8 commits into from
Feb 29, 2020

Commits on Feb 29, 2020

  1. Merge modifiers within popperOptions without breaking the arrow posit… 

    …ioning.
    @oliviertassinari
    Oliver Haynes authored and oliviertassinari committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    7dbebc2 View commit details
    Browse the repository at this point in the history

  2. Switched from manual merging of PopperProps to using deepmerge.

    @oliviertassinari
    Oliver Haynes authored and oliviertassinari committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    3f1dc76 View commit details
    Browse the repository at this point in the history

  3. Revert "Switched from manual merging of PopperProps to using deepmerge." 

    This reverts commit 3aad195.
    @oliviertassinari
    Oliver Haynes authored and oliviertassinari committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    73abd32 View commit details
    Browse the repository at this point in the history

  4. Added ability to merge default and custom arrow options.

    @oliviertassinari
    Oliver Haynes authored and oliviertassinari committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    d6ce8d8 View commit details
    Browse the repository at this point in the history

  5. Revert "Added ability to merge default and custom arrow options." 

    This reverts commit 3bdbfc6.
    @oliviertassinari
    Oliver Haynes authored and oliviertassinari committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    b33699e View commit details
    Browse the repository at this point in the history

  6. Revert "Revert "Switched from manual merging of PopperProps to using … 

    …deepmerge.""

This reverts commit e623048.
    @oliviertassinari
    Oliver Haynes authored and oliviertassinari committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    2b73388 View commit details
    Browse the repository at this point in the history

  7. I think this is the appropriate way to import the correct deepmerge u… 

    …til function. Unit tests still passing.
    @oliviertassinari
    Oliver Haynes authored and oliviertassinari committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    05bb637 View commit details
    Browse the repository at this point in the history

  8. migrate to testing-library

    @oliviertassinari
    oliviertassinari committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    0c7d2bb View commit details
    Browse the repository at this point in the history