Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Use node 10 in every CI/CD pipeline #19301

Merged
merged 3 commits into from
Jan 19, 2020
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jan 19, 2020

Dependencies are starting to bump their required node version (#19187 and #19299) since 8.x has reached its end of life. 10.x is now active LTS. We still officially support 8.x but to keep our test environment fast and safe we're switching to 10.x as should everybody else. If we start seeing regressions due to features being released that require 10.x we need to rethink our testing environment.

Azure pipeline was already using node 10. Netlify is controlled via environment variables.

@eps1lon eps1lon added the test label Jan 19, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Jan 19, 2020

No bundle size changes comparing bfe04ce...6f21469

Generated by 🚫 dangerJS against 6f21469

Reduce jargon and make exact node version used visible
@oliviertassinari
Copy link
Member

Should it impact the minimum version of node we support? In the documentation, we mention the LTS: https://material-ui.com/getting-started/supported-platforms/#server. Does it mean we can bump the min version from 8 to 10 without considering it a breaking change?

@eps1lon
Copy link
Member Author

eps1lon commented Jan 19, 2020

Does it mean we can bump the min version from 8 to 10 without considering it a breaking change?

I wouldn't do that since we support "node 8" not "node active maintenance".

I wouldn't use supported versions that change during the lifetime of a release e.g. react@16 but react@16.8 or node@8 but rather node@8.16.

I'll add a note to the docs in this PR about node 8 having reached end of life and that we don't use this environment. node 8 support is basically on the level of ie 11 support: bug reports do get addressed but we don't run automated tests on that environment.

@oliviertassinari
Copy link
Member

LTS versions that are in maintenance are supported. Right now, it supports node v8.x

I was under the assumption that the support is not bound to a specific version. The oldest LTS in maintenance is v10 now.

@eps1lon
Copy link
Member Author

eps1lon commented Jan 19, 2020

LTS versions that are in maintenance are supported. Right now, it supports node v8.x

I was under the assumption that the support is not bound to a specific version. The oldest LTS in maintenance is v10 now.

Because Material-UI supports server-side rendering, it needs to support the latest, stable releases of Node.js. Where possible, the LTS versions that are in maintenance are supported. Right now, it supports node v8.x and newer versions.

-- https://material-ui.com/getting-started/supported-platforms/#supported-platforms

It's quite ambiguous. Still the usual applies:

Don't break peoples code unless you have to.

@oliviertassinari
Copy link
Member

Ok, I have added a note in the v5 breaking change list, so we clear that up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants