Show focus if button gets tabbed INTO #1458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusk
changed the title
|
@mariusk Thanks for this - It seems as though we should be listening for tab presses on the window instead of on the actual button? This might be a flaw in the original implementation of EnhancedButton. What do you think? |
|
I agree and I'm sure you're right. But keep in mind I'm ignorant on most of the inner workings, so it's just my $0.000002. |
|
@hai-cea Tested it and it seems to work fine. Great job, thanks! |
|
Thanks @mariusk ! |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
* Clear dependencies * Update packages
zannager
added
the
component: button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a form, if the button gets tabbed into (e.g. from a TextView), the initial focus isn't handled properly (no visible sign that the button now has focus). Added check for tab key in keyUp handler which seems to solve it.