Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Slider issue #1448 #1451

Merged
merged 2 commits into from
Aug 21, 2015
Merged

Fix Slider issue #1448 #1451

merged 2 commits into from
Aug 21, 2015

Conversation

KapJI
Copy link
Contributor

@KapJI KapJI commented Aug 18, 2015

There are two issues which cause #1448:

  1. overflow is hidden in FocusRipple by default
  2. _setRippleSize() ignores existing el.top value
    This fixes both.

@KapJI KapJI mentioned this pull request Aug 20, 2015
Merged
hai-cea added a commit that referenced this pull request Aug 21, 2015
@hai-cea
Merge pull request #1451 from KapJI/slider-fix
ed7e830 
Fix Slider issue #1448
@hai-cea hai-cea merged commit ed7e830 into mui:master Aug 21, 2015
@hai-cea
Copy link
Member

hai-cea commented Aug 21, 2015

Thanks @KapJI !

@snyk-bot snyk-bot mentioned this pull request Jun 26, 2021
Open
@zannager zannager added the component: slider This is the name of the generic UI component, not the React module! label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KapJI @hai-cea @zannager