[FlatButton] Add labelPosition prop. #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| type: 'string', | ||
| header: 'default: "right"', | ||
| desc: 'Place label before or after the passed children' | ||
| } |
|
@hai-cea good catch, fixed! |
| @@ -26,6 +26,7 @@ let FlatButton = React.createClass({ | |||
| disabled: React.PropTypes.bool, | |||
| hoverColor: React.PropTypes.string, | |||
| label: validateLabel, | |||
| labelPosition: React.PropTypes.oneOf(['left', 'right']), | |||
There was a problem hiding this comment.
I think these should be one of before or after. Since that is a truer indication of what it's doing.
vaiRk
force-pushed
the
flatbutton-labelposition
branch
from
94f3278
to
2e4198a
Compare
|
+1 Rebased, renamed to "before" and "after" and made |
hai-cea
added a commit
that referenced
this pull request
Aug 21, 2015
[FlatButton] Add labelPosition prop.
|
Thanks @vaiRk |
|
I have just tested the feature. I have an issue. I think that labelPosition should default to |
zannager
added
the
component: button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment FlatButtons always render the label before any passed children.
I've added a
labelPositionprop to allow changing the order of the elements.Defaults to
rightas I thought the most common use is adding a FontIcon or similar which is normally placed on the left hand side of the button.