Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DatePicker] Update DatePicker #1266

Merged
merged 5 commits into from
Sep 7, 2015
Merged

[DatePicker] Update DatePicker #1266

merged 5 commits into from
Sep 7, 2015

Conversation

jkruder
Copy link
Contributor

@jkruder jkruder commented Jul 26, 2015

DatePicker style has been updated to match updated design for DatePicker components. This introduces some breaking changes/new behaviors:

  1. When navigating months using the chevrons, the selected date will not change; only the display date. In order to affect the selectedDate you need to click/tap a date or change the year. Google's demo of month navigation does not change the selected date, just the month that is currently visible.
  2. No more double chevrons to navigate years as they are not part of the Material spec. These files have also been removed from svg-icons.
  3. Clicking/Tapping the year will bring up the year selection widget. Selecting a year will change the selected and display dates.

@jkruder
Copy link
Contributor Author

jkruder commented Jul 26, 2015

Addresses #1261 and mui/mui-x#7293

@hai-cea
Copy link
Member

hai-cea commented Jul 27, 2015

@jkruder Thank you for this! It's working great. Here's some of my feedback:

  1. Can you add a toggle to the docs site to enable/disable year selector please? Also, the docs should say that disableYearSelection is default: false rather than optional.
  2. I also found some space issues - would you to address them in this PR as well?

@jkruder
Copy link
Contributor Author

jkruder commented Jul 28, 2015

@hai-cea Can do. What spacing issues are you seeing?

@hai-cea
Copy link
Member

hai-cea commented Jul 29, 2015

@jkruder Here's a side by side comparison of the profile version. I may be able to do pixel measurements in photoshop if you'd like?
image

@jkruder
Copy link
Contributor Author

jkruder commented Jul 30, 2015

@hai-cea I should be ok, thanks though. I'll get to work on this list. If you see something else, let me know.

  • Looks like the header padding needs to be reduced
  • Spacing between the columns can be reduced
  • Reduce space between last row and buttons
  • Reduce font weight of title and increase font size

@hai-cea
Copy link
Member

hai-cea commented Jul 30, 2015

@jkruder The green one is actually the correct version. Teal is the current one in MUI. So, spacing should be increased not reduced.

@jkruder
Copy link
Contributor Author

jkruder commented Jul 30, 2015

@hai-cea Thanks! I'll get the updates done soon.

@jkruder
Copy link
Contributor Author

jkruder commented Aug 1, 2015

@hai-cea Updated the docs and addressed spacing issues.

@acornejo
Copy link

acornejo commented Aug 3, 2015

This looks great, hopefully it will get merged soon.

@hai-cea
Copy link
Member

hai-cea commented Aug 3, 2015

@jkruder The picker is looking really great! 👍

Just found 2 small issues:

  1. Top right and left corners should be rounded.
  2. I wasn't able to get the disable year selector toggle to work? Year selection was still enabled despite the toggle.

@MrOrz
Copy link

MrOrz commented Aug 9, 2015

I've been trying using the update-datepicker branch.

While it looks pretty good in devtools (though not vertically centered):
2015-08-09 9 13 39

On mobile devices (mine is HTC M8 with Google Chrome), the browser header (location bar) still pushes the buttons to below the screen.
screenshot_2015-08-09-10-54-47

@jkruder
Copy link
Contributor Author

jkruder commented Aug 9, 2015

@MrOrz The vertical spacing at the top should be resolved by some of the dialog fixes that have come out. I haven't had time to merge in the latest and resolve @hai-cea's concerns. Should be done tonight though.

@jkruder
Copy link
Contributor Author

jkruder commented Aug 14, 2015

@hai-cea Running into some problems with border-radius and the dialog/paper. Trying to work a solution that does not modify dialog/paper. When I remove the paper background-color the border radius is applied correctly but when there is a background color you do not see the full 2px border radius.

@hai-cea
Copy link
Member

hai-cea commented Aug 14, 2015

@jkruder The container with the bgColor should have a border radius style.

@jkruder
Copy link
Contributor Author

jkruder commented Aug 14, 2015

@hai-cea Yes, I added the border radius style to the date display container but the border radius appears to not be applied. I'll push the changes tomorrow so you can take a look.

@oliviertassinari
Copy link
Member

Can you rebase? :)

hai-cea added a commit that referenced this pull request Sep 7, 2015
@hai-cea hai-cea merged commit b2faa18 into master Sep 7, 2015
@hai-cea
Copy link
Member

hai-cea commented Sep 7, 2015

Thanks @jkruder @oliviertassinari

@hai-cea hai-cea deleted the update-datepicker branch September 24, 2015 20:32
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 10, 2020
* Open picker by space/enter click

* Change new prop name to not conflict with current onOpen

* Use only enter to open

* Fix comment
@zannager zannager added component: date picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module! labels Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: date picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants