Added support for linkedState mixin in Tabs #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zadielerick
force-pushed
the
NewTabsv0.11
branch
from
107e068
to
40a5e56
Compare
| @@ -101,7 +101,7 @@ class TabsPage extends React.Component { | |||
| infoArray: [ | |||
| { | |||
| name: 'onChange', | |||
| type: 'function(e, tab)', | |||
| type: 'function(value, e, tab)', | |||
| header: 'optional', | |||
| desc: 'Fired on touch or tap of a tab. Passes the index and the tab element.' | |||
There was a problem hiding this comment.
@Zadielerick This description in not correct since we're not passing the index anymore.
Zadielerick
force-pushed
the
NewTabsv0.11
branch
from
40a5e56
to
3d976f1
Compare
|
@hai-cea Changed the description of onChange in the docs |
hai-cea
added a commit
that referenced
this pull request
Jul 22, 2015
Added support for linkedState mixin in Tabs
Merged
zannager
added
the
component: tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.