Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] MouseOver/MouseOut -> MouseEnter/MouseLeave #1190

Merged
merged 2 commits into from
Jul 17, 2015

Conversation

cgestes
Copy link
Contributor

@cgestes cgestes commented Jul 17, 2015

Improves performances by not handling child events.

This avoid glitches. For example in ListItem with the former code, the event was called each time the mouse was over a child, generating a lot of false positive.

Improves performances by not handling child events.

This avoid glitches. For example in ListItem with the former code, the event was called each time the mouse was over a child, generating a lot of false positive.
@cgestes
Copy link
Contributor Author

cgestes commented Jul 17, 2015

it needs review.

I removed did not remove mouseout/mouseover of menu as it seemed useful.

@cgestes cgestes changed the title MouseOver/MouseOut -> MouseEnter/MouseLeave [Performance] MouseOver/MouseOut -> MouseEnter/MouseLeave Jul 17, 2015
do not rerender when hoverColor is not set.
@hai-cea
Copy link
Member

hai-cea commented Jul 17, 2015

@cgestes Thanks for this PR! It looks good to me.

hai-cea added a commit that referenced this pull request Jul 17, 2015
[Performance] MouseOver/MouseOut -> MouseEnter/MouseLeave
@hai-cea hai-cea merged commit 82024ac into mui:master Jul 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants