Clicking slider track advances the slider knob. #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jkruder For some reason, this fix isn't working for me. I see hover affects, but clicking does not advance the knob. |
|
@hai-cea I missed a line while refactoring. |
hai-cea
added a commit
that referenced
this pull request
Jul 9, 2015
Clicking slider track advances the slider knob.
|
Thanks @jkruder |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
* WrappedKeyboardPicker: send strictCompareDates prop * compareDateStrict: add tests
zannager
added
the
component: slider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1074. Clicking anywhere on the track advances the slider to that position. Updated onMouseDown event handler to track the X position and compare it against the X position in the onMouseUp event handler to prevent multiple events from firing after a drag.