Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I cant import components.less from bower #218

Closed
gabadi opened this issue Jan 9, 2015 · 3 comments · May be fixed by javifelices/material-ui#6 or javifelices/material-ui#11
Closed

I cant import components.less from bower #218

gabadi opened this issue Jan 9, 2015 · 3 comments · May be fixed by javifelices/material-ui#6 or javifelices/material-ui#11
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.

Comments

@gabadi
Copy link

gabadi commented Jan 9, 2015

I'm using bower for front end dependencies, when i import the components.less i can't compile the less because this dependency in slider.less

@import (inline) "../../../node_modules/react-draggable2/lib/styles.css";

The question is, if the react-draggable2 root can be put in a variable, so i can override it

Thanks!

@gpbl
Copy link
Contributor

gpbl commented Jan 10, 2015

I had that dependency giving me problems as well. Actually, being a very tiny style, i believe the import can be skipped by adding

.react-draggable, .react-draggable-dragging {
  user-select: none;
}

.react-draggable {
  position: relative;
}

to the material-ui's style.

@hai-cea what about removing that @import? When ok, we could have a vendors/react-draggable.less instead.

@stipsan
Copy link
Contributor

stipsan commented Jan 28, 2015

This also breaks compiling the material-ui less from another npm package.

@stipsan
Copy link
Contributor

stipsan commented Jan 28, 2015

Actually, disregard that.
If you do the following then the less is compiled just fine:

        .pipe(less({
            paths: [ path.join(__dirname, 'node_modules', 'react-draggable2', 'lib') ],
            plugins: [autoprefix, cleancss]
        })

ninjasort pushed a commit to ninjasort/material-ui that referenced this issue Feb 15, 2015
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
Projects
None yet
5 participants