Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LeftNav] Prop to disable swipe to open or start the gesture next to the border #1222

Closed
ferrannp opened this issue Jul 20, 2015 · 2 comments · Fixed by #1279
Closed

[LeftNav] Prop to disable swipe to open or start the gesture next to the border #1222

ferrannp opened this issue Jul 20, 2015 · 2 comments · Fixed by #1279
Labels
component: menu This is the name of the generic UI component, not the React module!

Comments

@ferrannp
Copy link

Hello!

I noticed I can swipe in any part of the page (left to right) and the LeftNav will open. Honestly, I saw a lot of weird behaviour on my phone (when scrolling up and down), sometimes I half open the LeftNav without wanting.

Two things that will be nice to have (one easier than other):

  • A prop to deactivate that gesture (so the menu button will open the LeftNav)
  • Trigger the swipe gesture only if the user starts it from the side border (like a native app)

What do you think?

@jkruder
Copy link
Contributor

jkruder commented Jul 21, 2015

I think it's a good idea. Not everyone wants/needs to support swiping so it would be nice to opt out of it (maybe we want to opt in?). What do you think @hai-cea? Should a swipe enabled property be opt in or opt out?

@hai-cea
Copy link
Member

hai-cea commented Jul 22, 2015

I think it's a good idea. I think the prop should be called disableSwipe default to false.

pomerantsev added a commit to pomerantsev/material-ui that referenced this issue Jul 28, 2015
pomerantsev added a commit to pomerantsev/material-ui that referenced this issue Jul 28, 2015
pomerantsev added a commit to pomerantsev/material-ui that referenced this issue Jul 28, 2015
pomerantsev added a commit to pomerantsev/material-ui that referenced this issue Jul 29, 2015
JAStanton pushed a commit to convoyinc/material-ui that referenced this issue Jul 30, 2015
igorbt pushed a commit to igorbt/material-ui that referenced this issue Aug 2, 2015
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added component: menu This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants