Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not includding of boundary years in getYearRange #377

Merged
merged 5 commits into from
Apr 27, 2018

Conversation

dmtrKovalenko
Copy link
Member

@dmtrKovalenko dmtrKovalenko commented Apr 27, 2018

  • I have changed my target branch to develop 👊

Closes #340

Description

Fis incorrect exclude of boundary years

docs/src/App.js Outdated
@@ -1,7 +1,7 @@
import React, { Component } from 'react';
import { MuiThemeProvider, createMuiTheme } from 'material-ui';

import Utils from 'material-ui-pickers/utils/date-fns-utils';
import Utils from 'material-ui-pickers/utils/moment-utils';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes are temporary, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have already return back that :)

lib/package.json Outdated
@@ -45,6 +45,7 @@
},
"dependencies": {
"babel-runtime": "^6.26.0",
"luxon": "^1.2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider moving this to devDependencies

Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmtrKovalenko dmtrKovalenko merged commit 0308cc0 into develop Apr 27, 2018
@cherniavskii cherniavskii deleted the feature/moment-getYearRange branch April 27, 2018 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants