[NumberField] Fix failing browser tests #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomiks
added
the
component: number field
atomiks
commented
Apr 15, 2024
atomiks
commented
Apr 15, 2024
Comment on lines
+139
to
+145
| try { | ||
| // Avoid non-deterministic errors in testing environments. This error sometimes | ||
| // appears: | ||
| // "The root document of this element is not valid for pointer lock." | ||
| // We need to await it even though it doesn't appear to return a promise in the | ||
| // types in order for the `catch` to work. | ||
| await ownerDocument(scrubAreaRef.current).body.requestPointerLock(); |
There was a problem hiding this comment.
Types suggest you don't need await, but I think you do for some browsers/envs?... 🫠
There was a problem hiding this comment.
Note: this error also sometimes appeared for document.body.requestPointerLock(), so it doesn't seem related to ownerDocument.
atomiks
force-pushed
the
fix/number-field-browser-tests
branch
from
96c2de8
to
5057e0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft to experiment, these somehow started failing after merge