Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend eZObjectRelationListType, move all docs to README.md, remove closing PHP tags #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pkamps
Copy link
Member

@pkamps pkamps commented Nov 21, 2017

Mugoobjectrelationlisttype now extends Objectrelationlisttype. It then can re-use a lot of functions from the parent class. It also benefits of bug fixes in the parent class functions.

All doc moved to README.md

Some code makup like removing closing '?>' php tag.

@peterkeung
Copy link
Member

+1

I did a code run-through of the removed functions, but I did not re-test the datatype to make sure nothing important was removed.

@peterkeung peterkeung changed the title Code review Extend eZObjectRelationListType, move all docs to README.md, remove closing PHP tags Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants