Introducing Configuration transporter #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit introduces two new configuration transporter classes for Solr and Zookeeper. It also moves the configuration synchronization method away from the eZSolr class into the new classes with a factory pattern implementation to instantiate the optimal transporter.
Moving 2 functions from ezfindelevateconfiguration.php into the newly created transporter class.
|
Comments: Questions: |
The changes allow flexibility when setting the configuration file path for the eZFConfigurationTransporterZookeeperCli class. Previously, the path was hardcoded into the class, but now it can be set via ConfigurationTransporterParameters in solr.ini.
|
You can now configure the path to the config file in the settings. Answers are in a separate email. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's only possible to syncronize the elevate configuration with a solr instance directly. At a client installation, we do have a different setup: the solr configuration is managed by zookeeper - a system to have high availability for solr.
This pull request introduces "Configuration transporter" classes. There is one for "solr" executing the existing syncronization and a new one for zookeeper. There is a factory function to chose a transporter based on the settings.