Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade to CUDA 12.5 #2601

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

reneleonhardt
Copy link
Contributor

Description

Features

  • Upgrade to CUDA 12.5
  • Add Docker tag suffix -cuda11

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for localai ready!

Name Link
🔨 Latest commit a128f67
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/66727e6140870b00088f3cd5
😎 Deploy Preview https://deploy-preview-2601--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -274,6 +278,33 @@ jobs:
run: |
echo "Image is available at ttl.sh/localai-ci-pr-${{ github.event.number }}:${{ steps.meta_pull_request.outputs.version }}" >> $GITHUB_STEP_SUMMARY
## End testing image
- name: Build and push CUDA 11
Copy link
Owner

@mudler mudler Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already push cuda-11 images as part of the build matrix here

- build-type: 'cublas'

I'm not sure if there is anything to add here, except changing image's defaults.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I'll remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makefile docker-aio-all: looks strange, a duplicated command, should that be removed or DOCKER_AIO_SIZE changed in the second call?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - that looks a leftover, should be dropped as its not used anymore! Thanks!

Signed-off-by: Rene Leonhardt <65483435+reneleonhardt@users.noreply.github.com>
@mudler
Copy link
Owner

mudler commented Jun 19, 2024

Looking good! thank you @reneleonhardt !

@mudler mudler merged commit 43f0688 into mudler:master Jun 19, 2024
32 checks passed
@mudler mudler added the enhancement New feature or request label Jun 19, 2024
@reneleonhardt
Copy link
Contributor Author

@mudler FYI Nvidia seems to support Ubuntu LTS from April now:
https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2404/x86_64/
Maybe check your Docker images for security fixes, then CUDA 12.5 could be built with a new base image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants