Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace own vector search with Chromem-go #2065

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

richiejp
Copy link
Collaborator

Because my implementation is apparently not producing the expected
results and this project fits the bill quite nicely.

Most of the tests are failing, but the core functionality appears to
work.

  • Set
  • Get
  • Delete (we have to delete the whole collection presently)
  • Query (it returns normalized embeddings, not the originals)
  • Query Normalized

Some features are missing from Chromem, but we don't strictly need
them. Meanwhile there are maybe some minor things that need adding on
our side to get the basic functionality working.

Because my implementation is apparently not producing the expected
results and this project fits the bill quite nicely.

Most of the tests are failing, but the core functionality appears to
work.

- [x] Set
- [ ] Get
- [ ] Delete (we have to delete the whole collection presently)
- [ ] Query (it returns normalized embeddings, not the originals)
- [x] Query Normalized

Some features are missing from Chromem, but we don't strictly need
them. Meanwhile there are maybe some minor things that need adding on
our side to get the basic functionality working.
Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for localai canceled.

Name Link
🔨 Latest commit 49df11b
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/6620e80f23bc59000838d17e

@mudler
Copy link
Owner

mudler commented Apr 18, 2024

re: deletion, we might want to implement a .Reset() to discard and cleanup the memory?

@richiejp
Copy link
Collaborator Author

Yes, I think so. Also I think we need to add IDs to the API (so the vector is not being used for that).

part of #1792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants