-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/fix: OSX Test Repair #1843
Conversation
…ugging line to Dockerfile that I've found helpful recently.
✅ Deploy Preview for localai canceled.
|
test-models/testmodel
@@ -105,9 +105,12 @@ jobs: | |||
- name: Test | |||
run: | | |||
GO_TAGS="stablediffusion tts" make test | |||
- name: Setup tmate session if tests fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ouch, better to not commit this - if something fails then tmate will be hanging in there waiting for someone to connect and will exhaust all the CIs..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mudler What do you think about using
timeout-minutes: 5
instead?
Apparently we can tune how long it sits around waiting - my thought locking these in place on every failure was that's easier than the alternative the docs for the action recommend, which is to use manual dispatches with an event like if: ${{ github.event_name == 'workflow_dispatch' && inputs.debug_enabled }}
I'm not wed to any particular wait duration... I'd just like it to be longer than 1 minute so I have a chance to notice and connect :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also only put it on these two test runners rather than any of the builders to try and keep the wait pressure down FYI
…0.1 by renovate (#19487) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker.io/localai/localai](https://togithub.com/mudler/LocalAI) | patch | `v2.10.0-cublas-cuda11-ffmpeg-core` -> `v2.10.1-cublas-cuda11-ffmpeg-core` | | [docker.io/localai/localai](https://togithub.com/mudler/LocalAI) | patch | `v2.10.0-cublas-cuda11-core` -> `v2.10.1-cublas-cuda11-core` | | [docker.io/localai/localai](https://togithub.com/mudler/LocalAI) | patch | `v2.10.0-cublas-cuda12-ffmpeg-core` -> `v2.10.1-cublas-cuda12-ffmpeg-core` | | [docker.io/localai/localai](https://togithub.com/mudler/LocalAI) | patch | `v2.10.0-cublas-cuda12-core` -> `v2.10.1-cublas-cuda12-core` | | [docker.io/localai/localai](https://togithub.com/mudler/LocalAI) | patch | `v2.10.0-ffmpeg-core` -> `v2.10.1-ffmpeg-core` | | [docker.io/localai/localai](https://togithub.com/mudler/LocalAI) | patch | `v2.10.0` -> `v2.10.1` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>mudler/LocalAI (docker.io/localai/localai)</summary> ### [`v2.10.1`](https://togithub.com/mudler/LocalAI/releases/tag/v2.10.1) [Compare Source](https://togithub.com/mudler/LocalAI/compare/v2.10.0...v2.10.1) <!-- Release notes generated using configuration in .github/release.yml at master --> ##### What's Changed ##### Bug fixes 🐛 - fix(llama.cpp): fix eos without cache by [@​mudler](https://togithub.com/mudler) in [mudler/LocalAI#1852 - fix(config): default to debug=false if not set by [@​mudler](https://togithub.com/mudler) in [mudler/LocalAI#1853 - fix(config-watcher): start only if config-directory exists by [@​mudler](https://togithub.com/mudler) in [mudler/LocalAI#1854 ##### Exciting New Features 🎉 - deps(whisper.cpp): update, fix cublas build by [@​mudler](https://togithub.com/mudler) in [mudler/LocalAI#1846 ##### Other Changes - fixes [#​1051](https://togithub.com/mudler/LocalAI/issues/1051): handle openai presence and request penalty parameters by [@​blob42](https://togithub.com/blob42) in [mudler/LocalAI#1817 - fix(make): allow to parallelize jobs by [@​cryptk](https://togithub.com/cryptk) in [mudler/LocalAI#1845 - fix(go-llama): use llama-cpp as default by [@​mudler](https://togithub.com/mudler) in [mudler/LocalAI#1849 - ⬆️ Update docs version mudler/LocalAI by [@​localai-bot](https://togithub.com/localai-bot) in [mudler/LocalAI#1847 - ⬆️ Update ggerganov/llama.cpp by [@​localai-bot](https://togithub.com/localai-bot) in [mudler/LocalAI#1848 - test/fix: OSX Test Repair by [@​dave-gray101](https://togithub.com/dave-gray101) in [mudler/LocalAI#1843 **Full Changelog**: mudler/LocalAI@v2.10.0...v2.10.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNTYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI1Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
make clean-tests
wipes out the test models to avoid having to remember to delete both models and dir. Only invoked manually!Adds a simple RUN echo... line to Dockerfile - helpful when diagnosing errors related to errors caused by this sort of thing
adds "tmate On Failure" step to each of the test workflows - most useful place to debug CI issues.
Upgrades CI to run OSX tests on OSX14 + ARM instead of OSX13 + x64