Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for django 3 #57

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Conversation

ChrisBurch
Copy link
Contributor

@ChrisBurch ChrisBurch commented Dec 9, 2019

Thanks for such a handy library! Here's a PR to make it compatible with Django 3.0.

- django.shortcuts.render_to_response was deprectated in 2.0, and removed in 3.0. Changed function reference to its replacement, render() (https://docs.djangoproject.com/en/2.2/topics/http/shortcuts/#render-to-response)
- adding Django 3.0 to tox
- fix tox (django 3 doesn't support python 3.5)
- update static file loading, which caused an exception on Django 3 (https://stackoverflow.com/questions/24238496/what-is-the-difference-between-load-staticfiles-and-load-static)
@ChrisBurch
Copy link
Contributor Author

Friendly ping on this... Is this repo still semi-watched-over by anyone?
@sztamas
@id2359

@sztamas
Copy link
Contributor

sztamas commented Dec 13, 2019

Hi @ChrisBurch,

The history of the project is that I developed it originally on my own time, but then Murdoch University (my employer at the time) - started using it for a few Django projects, so I've donated the project to them, but I still managed the project mostly on my own: fixes, upgrades, releases etc as required.

I've left Murdoch University almost a year ago and I stopped responding to requests on the project as I don't have ownership of the project anymore.

I see there isn't anyone actively looking after the project and I would be happy to maintain it again if muccg would transfer the ownership of the project back to me.

@id2359 any chance of you transferring the project ownership back from muccg to my GitHub user (sztamas)?

Thanks,

Tamas

@ChrisBurch
Copy link
Contributor Author

Ah got it, thanks for the context Tamas! We'll wait to hear back from someone at muccg then.

Best,
Chris

@n4cr
Copy link

n4cr commented Jan 20, 2020

Another friendly reminder if this can be merged.

Thanks

@eriktelepovsky
Copy link

+1

@id2359 id2359 merged commit 41473a4 into muccg:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants