fix(WebSocket): treat interceptor exceptions as closures with error #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
commented
Aug 6, 2024
| * closures with error. This prevents from the exceptions occurring | ||
| * in `queueMicrotask` from being process-wide and uncatchable. | ||
| */ | ||
| if (error instanceof Error) { |
There was a problem hiding this comment.
Ignore non-errors being thrown.
25 tasks
kettanaito
force-pushed
the
fix/ws-interceptor-exception
branch
from
4ccb0d3
to
cdac523
Compare
Released: v0.34.1 🎉This has been released in v0.34.1! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the
onUnhandledExceptionevent in MSW, I noticed that unhandled exceptions in theconnectionlistener are thrown on the entire process and are uncatchable. That's caused by theconnectionevent being emitted in thequeueMicrotaskin the WebSocket interceptor. The queuing itself is correct.I'm solving this by catching those interceptor exceptions and translating them to WebSocket connection closure with error. This means an unhandled interceptor exception will trigger
errorandcloseevents, and also print the caught error to stderr.