Update core data in main thread

mssun · Feb 18, 2020 · 2dc8182 · 2dc8182
1 parent 133ad1b
commit 2dc8182
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/passKit/Models/PasswordStore.swift b/passKit/Models/PasswordStore.swift
@@ -235,8 +235,8 @@ public class PasswordStore {
         try storeRepository.pull(storeRepository.currentBranch(), from: remote, withOptions: options, progress: progressBlock)
         Defaults.lastSyncedTime = Date()
         self.setAllSynced()
-        self.updatePasswordEntityCoreData()
         DispatchQueue.main.async {
+            self.updatePasswordEntityCoreData()
             NotificationCenter.default.post(name: .passwordStoreUpdated, object: nil)
         }
     }
@@ -566,7 +566,9 @@ public class PasswordStore {
 
     public func saveUpdatedContext() {
         do {
-            try context.save()
+            if context.hasChanges {
+                try context.save()
+            }
         } catch {
             fatalError("FailureToSaveContext".localize(error))
         }