Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: set delete ids to context #138

Merged
merged 1 commit into from
Aug 10, 2024
Merged

✨ feat: set delete ids to context #138

merged 1 commit into from
Aug 10, 2024

Conversation

lwnmengjing
Copy link
Member

Description

mss-boot-io/mss-boot-admin#147

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (main)
  • no unintentional fmt.Print left behind after debugging
  • did I name variables, methods and classes according to the naming rules? (https://go.dev/doc/effective_go#names)
  • caught exceptions or throw them to the upper level for processing, not ignored (https://go.dev/doc/effective_go#errors)
  • did I explain all possible solutions and why I chose the one I did?
  • added any comments to make new functions clearer
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors
  • instructions for how reviewers can test the code locally
  • screenshot of the feature/bug fix (if applicable)

@lwnmengjing lwnmengjing added the enhancement New feature or request label Aug 9, 2024
@lwnmengjing lwnmengjing merged commit 2ea7f0e into main Aug 10, 2024
3 checks passed
@lwnmengjing lwnmengjing deleted the feat/menu branch August 10, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants