Add color diff for small dataframe comparison #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@happytomatoe May you take a look on the failed tests, please? |
|
@SemyonSinchenko Now tests are completing successfully. Could you please take a look? |
zeotuan
reviewed
Aug 31, 2024
src/main/scala/com/github/mrpowers/spark/fast/tests/DataframeUtil.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/github/mrpowers/spark/fast/tests/DataframeUtil.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/github/mrpowers/spark/fast/tests/DataframeUtil.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/github/mrpowers/spark/fast/tests/DataframeUtil.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/github/mrpowers/spark/fast/tests/DataframeUtil.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/github/mrpowers/spark/fast/tests/DataFrameComparer.scala
Show resolved
Hide resolved
alfonsorr
reviewed
Sep 2, 2024
src/main/scala/com/github/mrpowers/spark/fast/tests/DataframeUtil.scala
Outdated
Show resolved
Hide resolved
zeotuan
approved these changes
Sep 3, 2024
src/main/scala/com/github/mrpowers/spark/fast/tests/DataframeUtil.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/github/mrpowers/spark/fast/tests/ufansi/FansiExtensions.scala
Outdated
Show resolved
Hide resolved
SemyonSinchenko
approved these changes
Sep 3, 2024
alfonsorr
approved these changes
Sep 3, 2024
|
@SemyonSinchenko Do you plan for a release? |
We have a couple of blocking tickets, related to the release process (#46 is an example). But I think we can try make a minor release without sources... Let me discuss it internally with @MrPowers and @alfonsorr P.S. I created #149 for tracking of the new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I am always annoyed that I have to diff go to text compare website and compare the actual and expected version when using dataframes. That's why I've created this PR.
Before
After
WDYT?