ISSUE-316: fix support for mixed base directories #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmlnc
force-pushed
the
ISSUE-316_fix_mixed_base_directories
branch
from
96b6bcc
to
7e28a63
Compare
mrmlnc
force-pushed
the
ISSUE-316_fix_mixed_base_directories
branch
from
7e28a63
to
4c36f6d
Compare
This was referenced Jun 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
This is a fix for #316 and #310.
What changes did you make? (Give an overview)
Now we do not group patterns to the global task when at least one base directory refers to the parent directory.
Right now we don't support patterns like
{.,..}/../*.md. We'll leave that for the future due to the complexity of implementation.