Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(commands): move util function to toolbox #416

Closed
wants to merge 1 commit into from

Conversation

hinell
Copy link
Contributor

@hinell hinell commented Oct 19, 2023

I actually wanted to include this patch into #415 PR, but decided to go separately.

How to Test

N/A

Testing for Regressions

I have tested the following:

  • Triggering keymaps from legendary.nvim in all modes (normal, insert, visual)
  • Creating keymaps via legendary.nvim, then triggering via the keymap in all modes (normal, insert, visual)
  • Triggering commands from legendary.nvim in all modes (normal, insert, visual)
  • Creating commands via legendary.nvim, then running the command manually from the command line
  • augroup/autocmds created through legendary.nvim work correctly

@mrjones2014
Copy link
Owner

What's the purpose of this PR?

@hinell
Copy link
Contributor Author

hinell commented Oct 20, 2023

@mrjones2014 Refactoring. That function might be used elsewhere, so it's logical to keep it in tool box.

@mrjones2014
Copy link
Owner

That function might be used elsewhere

But it isn't currently. We can move it if/when it's needed.

@mrjones2014
Copy link
Owner

Toolbox is supposed to be more for end-user utilities, this is an internal parser.

@hinell hinell deleted the commands-refactor branch October 20, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants