Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples: Clean up. #28929

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Examples: Clean up. #28929

merged 1 commit into from
Jul 21, 2024

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Jul 21, 2024 •
edited
Loading

Related issue: N/A

Description

This line is incorrect:

lutPass.lutNode = texture3D( lutMap[ params.lut ] );

it should be:

lutPass.lutNode = texture3D( lutMap[ params.lut ].texture3D );

Additionally the Lut3DNodes size is not initialized, so I fixed that as well.

@Mugen87 Mugen87 merged commit b47c7e7 into mrdoob:dev Jul 21, 2024
11 checks passed
@Mugen87 Mugen87 modified the milestones: r168, r167 Jul 21, 2024
@Methuselah96 Methuselah96 deleted the 3dlut-fixes branch July 21, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r167
Development

Successfully merging this pull request may close these issues.
2 participants
@Methuselah96 @Mugen87