NodeMaterial: Honor ambientOcclusion in basic, lambert and phong.
#28819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
sunag
reviewed
Jul 6, 2024
| reflectedLight.indirectDiffuse.assign( diffuseColor.rgb ); | ||
| reflectedLight.indirectDiffuse.addAssign( diffuseColor.rgb ); | ||
|
|
||
| reflectedLight.indirectDiffuse.mulAssign( ambientOcclusion ); |
There was a problem hiding this comment.
I was thinking in we move this to LighthingModel.ambientOcclusion(), since we already have this function.
There was a problem hiding this comment.
Um, maybe it is easier to read the code when the final computation of indirect diffuse (accumulation + modulation) happens at one place.
Although when the line is moved to LighthingModel.ambientOcclusion(), we don't have to repeat it in derived models. I'm just afraid it will make it more hard to understand the lighting models in the end...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #28785
Description
Basic, lambert and phong materials now support ambient occlusion.