Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: ChainMap - Clean up. #28492

Merged
merged 1 commit into from
May 26, 2024
Merged

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented May 26, 2024

Related issue: N/A

Description

Removed the dead branches that call super, since ChainMap no longer extends WeakMap (as of #26079). Also removed the unused ChainMap.dispose() method since it was calling the deprecated/removed WeakMap.clear(). ChaingMap.dispose() was never getting called because all usages of ChainMap just dereference the ChainMap when disposing.

@sunag sunag added this to the r165 milestone May 26, 2024
@sunag sunag merged commit d40187b into mrdoob:dev May 26, 2024
11 checks passed
@sunag sunag changed the title ChainMap: Clean up. WebGPURenderer: ChainMap - Clean up. May 26, 2024
@Methuselah96 Methuselah96 deleted the chain-map-cleanup branch May 27, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants