Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Fixed ghost background and environment issue in a New-ed app #28251

Merged
merged 1 commit into from
May 2, 2024

Conversation

ycw
Copy link
Contributor

@ycw ycw commented May 1, 2024

The issue: ghost background and environment remains in a New-ed app's UI:

dirty.mp4

This PR fixed this UI issue by explicitly assigning null to scene background's UITexture and scene environment's UITexture, in turn viewport.js will assign null to scene.background on sceneBackgroundChanged (same for scene.environment), in this way no ghost textures will be shown in UITexture and Viewport, in a New-ed app:

clean.mp4

Preview: https://raw.githack.com/ycw/three.js/editor-cleared/editor/index.html

@ycw ycw changed the title Editor: Fixed ghost background and environment on editor.clear() Editor: Fixed ghost background and environment issue in a New-ed app May 1, 2024
@Mugen87 Mugen87 added this to the r165 milestone May 1, 2024
@Mugen87 Mugen87 merged commit 5a6eb7a into mrdoob:dev May 2, 2024
7 of 11 checks passed
@ycw ycw deleted the editor-cleared branch May 2, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants