Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KTX2Loader: Remove RGB_S3TC_DXT1_Format usage. #28069

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 4, 2024

Fixed #26124.

Description

see #28035 (comment).

This PR ensures KTX2Loader does not produce compressed texture with RGB_S3TC_DXT1_Format which isn't supported in WebGPU. RGBA_S3TC_DXT1_Format is used instead.

Copy link
Collaborator

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@mrdoob mrdoob merged commit 9870c85 into mrdoob:dev Apr 5, 2024
11 checks passed
@Mugen87 Mugen87 added this to the r164 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebGPU: Support more texture formats transcoded from KTX2
3 participants