Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3MFLoader: Throw error on missing rels. #27955

Merged
merged 2 commits into from
Mar 21, 2024
Merged

3MFLoader: Throw error on missing rels. #27955

merged 2 commits into from
Mar 21, 2024

Conversation

nmattia
Copy link
Contributor

@nmattia nmattia commented Mar 20, 2024

Related issue: #27947

Description

This throws an error in case the 3MF file is malformed and is missing the rels object. Otherwise, the error is a bit cryptic.

This throws an error in case the 3MF file is malformed and is missing
the `rels` object. Otherwise, the error is a bit cryptic.
@Mugen87 Mugen87 changed the title THREE.ThreeMFLoader: Throw error on missing rels 3MFLoader: Throw error on missing rels. Mar 20, 2024
@Mugen87 Mugen87 added this to the r163 milestone Mar 20, 2024
examples/jsm/loaders/3MFLoader.js Outdated Show resolved Hide resolved
@Mugen87 Mugen87 merged commit cde048c into mrdoob:dev Mar 21, 2024
11 checks passed
@nmattia nmattia deleted the nm-dev branch March 21, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants