Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Use WebXR's offerSession when available #27773

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Editor: Use WebXR's offerSession when available #27773

merged 1 commit into from
Feb 19, 2024

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Feb 19, 2024

@mrdoob mrdoob added this to the r162 milestone Feb 19, 2024
@mrdoob mrdoob merged commit 698079a into dev Feb 19, 2024
9 of 10 checks passed
@mrdoob mrdoob deleted the editor-xr branch February 19, 2024 07:57
@cabanier
Copy link
Contributor

awesome! thanks

@mrdoob
Copy link
Owner Author

mrdoob commented Feb 20, 2024

@cabanier The editor no longer loads on the Quest Pro after this PR.

a7a523ab85b786d8f0802aa2d808c4c4

@cabanier
Copy link
Contributor

o woah! The crash corgi!
Can you hit the oculus button 5 times and file a bugreport?
Also if you have adb can you do adb logcat > out.txt, reproduce the crash and send me the log file?

@mrdoob
Copy link
Owner Author

mrdoob commented Feb 20, 2024

I don't have adb unfortunately...

Are you able to reproduce on your Quest Pro?

@cabanier
Copy link
Contributor

I'm on PTO this week. I'll forward to my team

@mrdoob
Copy link
Owner Author

mrdoob commented Feb 20, 2024

I've filled a bug report. It crashes on Quest 3 too.

@cabanier
Copy link
Contributor

how do you reproduce? Just open the URL above and go immersive?

We got your report.

@mrdoob
Copy link
Owner Author

mrdoob commented Feb 21, 2024

Just trying to open the URL is enough. The browser will try a few times and then corgi appears.

@sylwesterdigital
Copy link

o woah! The crash corgi! Can you hit the oculus button 5 times and file a bugreport? Also if you have adb can you do adb logcat > out.txt, reproduce the crash and send me the log file?

I have attached an adb log if this still is valid from the corgi circular loop.
threejs-editor-corgi-adb-log.txt

@cabanier
Copy link
Contributor

I found the issue on our side. You're calling offerSession very soon after page load at which point we didn't initialize WebXR yet.
I will fix this for the next browser version.

@mrdoob
Copy link
Owner Author

mrdoob commented Feb 26, 2024

Excellent. What browser version will that be?

@cabanier
Copy link
Contributor

Excellent. What browser version will that be?

Either 32.0 or 32.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants