Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quaternion: correct the quaternion random() method #27724

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

WestLangley
Copy link
Collaborator

Follow-on to #22494

The current code references an outdated link, which implemented an algorithm using a different quaternion convention.

This PR references the the original source, and follows the original sources's nomenclature. The original source and three.js use the same [ x, y, z, w ] quaternion convention.

@WestLangley WestLangley added this to the r162 milestone Feb 10, 2024
Copy link

github-actions bot commented Feb 10, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
676.1 kB (168.2 kB) 676.1 kB (168.2 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
457.2 kB (111 kB) 457.2 kB (111 kB) +0 B

@WestLangley WestLangley force-pushed the dev-quaternion_random branch 2 times, most recently from 6864128 to d52a4dc Compare February 10, 2024 20:55
@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 11, 2024

webgl_instancing_performance uses Quaterion.random(). It seems this PR causes a change in behavior so the screenshot of webgl_instancing_performance requires an update.

@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 11, 2024

Regarding #27725 (comment).

@WestLangley Do you have the same issue in this PR as well?

@Mugen87 Mugen87 merged commit 4d81ce8 into mrdoob:dev Feb 11, 2024
20 of 22 checks passed
@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 11, 2024

Maybe you have not updated the builds before generating the screenshots? That happened to me last time.

@WestLangley
Copy link
Collaborator Author

Yes, same issue.

@WestLangley WestLangley deleted the dev-quaternion_random branch February 12, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants